feat: enable Basic var and List var to coexist for the local search#1606
Conversation
|
@triceo I plan to add documentation about the mixed model once I finish the quick-start change, as I'll have concrete models to use in the explanation. |
755fe45 to
1a78122
Compare
triceo
left a comment
There was a problem hiding this comment.
This continues to be suspiciously simple. I am really surprised.
Did you test what happens when strength/difficulty comparisons are used? Did you check entity/value sorter manner? We do not support some of it with list variables, and we need to make sure that this does not change here; and the use cases which work still need to work in the mixed mode.
If there is coverage for the mentioned features, then we know the default behavior remains unchanged. I'll ensure to add tests for the relevant features. |
1a78122 to
06da606
Compare
165e5c2 to
8223d2c
Compare
5c951a8 to
185e79c
Compare
e4ba841 to
014d677
Compare
triceo
left a comment
There was a problem hiding this comment.
LGTM after comments resolved.
ef2e929 to
11af3d6
Compare
|



This PR completes the feature and enables the mixed model for local search.